<< Programming Naming Conventions | My Development Environment at home >>

Why are code reviews important?

Tags: code reviews, development | Categories: development Posted by pieterg on 2/10/2010 7:09 PM | Comments (39)

In January of 2006, Jeff wrote a post about why Code Reviews are important and I agree 100% that it's the only way to improve yourself as a developer.
He also pointed to Karl E. wiegers book titled - "Peer Reviews in Software".

It's all about sharing and caring about your code and the product you are building.

You might ask what you should check for in code reviews?

1. Is it readable? Has the coding standards been maintained?
2. Determine what the code is supposed to do.
3. Determine what the code is currently doing and how it's doing it, is it doing it effeciently?
4. Have a look at the individual modules. If an object is called Person, make sure that the object describes a person fully and completely and only maintain a "person's" responsibility. Ask questions like, should this person object be able to make updates to a database or should there be a DatabaseContext object that handles this by accepting a person as a parameter. databaseContext.UpdatePerson(Person person);

The most value comes from talking to the other developer and learning from them and they might just make you realize that there are things that you haven't thought of. Libraries that might have made your life easier, reduced the time that you spent on writing a section of code.

d23f3db9-d9cd-4071-bf67-893dea370edc|0|.0

What came first? Code or DB? Are we developing the wrong way around?It’s difficult to break away from old traditions, but sometimes it pays to think a differently. NHib...Some interesting code I wrote.So, I recently had the chance to quickly write some code that gave me the ability to quickly get dat...Mocking your code! NAH!When I write unit tests, I always have some type of mock object to work against. I stumbled acr...

Comments

Resources like the one you mentioned here will be very useful to me! I will post a link to this page on my blog. I am sure my visitors will find that very useful.

Pretty good post. I just stumbled upon your blog and wanted to say that I have really enjoyed reading your blog posts. Any way I'll be subscribing to your feed and I hope you post again soon.

I admire the valuable information you offer in your articles. I will bookmark your blog and have my children check up here often. I am quite sure they will learn lots of new stuff here than anybody else!

Nice to be visiting your blog again, it has been months for me. Well this article that i've been waited for so long. I need this article to complete my assignment in the college, and it has same topic with your article. Thanks, great share.

You really make it seem so easy with your presentation but I find this topic to be really something which I think I would never understand. It seems too complicated and very broad for me. I am looking forward for your next post, I will try to get the hang of it!

I was wondering what is up with that weird gravatar??? I know 5am is early and I'm not looking my best at that hour, but I hope I don't look like this! I might however make that face if I'm asked to do 100 pushups. lol

Thank you for posting this one. I enjoy reading your article. I like to bookmark this page.

Do you accept guest posts? I would love to write couple articles here.
I was wondering what is up with that weird gravatar??? I know 5am is early and I'm not looking my best at that hour, but I hope I don't look like this! I might however make that face if I'm asked to do 100 pushups. lol

Fantastic post! This could aid lots of people find out about this matter. Do you want to incorporate video clips together with these? It could undoubtedly help out. Your reason was spot on and owing to you; I probably won't have to describe everything to my pals. I can simply direct them here

Heard about this site from my friend. He pointed me here and told me I’d find what I need. He was right! I got all the questions I had, answered. Didn’t even take long to find it. Love the fact that you made it so easy for people like me. More power

I think am having some problems with accessing this blog in old Firefox.

I'm quite new to wordpress. but what you write in this post is really good and very informative. I think it will help me in the future. Thanks for the great work.

Yeah, true..

Thanks for sharing, please keep an update about this info. love to read it more. i like this site too much. Good theme ;).

Thanks for sharing good info.

Hello is Blogengine a free blogging software like wordpress? Additionally does it have lots of plugins and themes for it? I would like to start using it for my new website if it does. Thank You

Thanx for the effort, keep up the good work Great work, I am going to start a small Blog Engine course work using your site I hope you enjoy blogging with the popular BlogEngine.net.Thethoughts you express are really awesome. Hope you will right some more posts.

I can only smirk as I read this stuff. All I can do was smile in agreement! Ok.

The blog was absolutely fantastic! Lots of great information and inspiration, both of which we all need!b Keep 'em coming... you all do such a great job..

I've been studying alot on this over the past few months, can you reccomend any well known websites that offer certification training on the matter? I definitely need help passing my next certification test.

More info about 2010

code reviews are very important, I found out the hard way!

Thanks very much! I genuinely enjoyed reading this. It makes me want to make my own blog. I do not know what topic though? I am a order entry clerk but can't conceive of many people wanting to read about that! Maybe I'm wrong. Any ideas?

By far the most concise and up to date information I found on this topic. Sure glad that I navigated to your page by accident. I’ll be subscribing to your feed so that I can get the latest updates. Appreciate all the information here

Hey, have yo? tried electronic cigarette?.

I just wanted to write, whatever issues I may disagree with you, you have a great insisght into my residence every day.

Hello,

I like very much what you have mentioned here.It will be very useful to me.I am sure this is very helpful for those who want to know about it.Thank you for posting this one. I enjoy reading your article.

I would just say one thing to you and that is, “FANTASTIC”!! Keep it up and wish to get more details from your blog.

I have discovered and learned much from your blog. Your blog is really good.

Thank you for this helpfull review. It really was helpfull. Keep up the good work.

I\'m happy I found this blog, I couldnt discover any info on this subject matter prior to. I also run a site and if you want to ever serious in a little bit of guest writing for me if possible feel free to let me know, i\'m always look for people to check out my site. Please stop by and leave a comment sometime!

Hey - nice blog, just looking around some blogs, seems a pretty nice platform you are using. I'm currently using Wordpress

Have you ever considered adding more videos to your blog posts to keep the readers more entertained? I mean I just read through the entire article of yours and it was quite good but since I'm more of a visual learner,I found that to be more helpful well let me know how it turns out

Took me time to read all the comments, but I really enjoyed the article. It proved to be Very helpful to me and I am sure to all the commenters here It's always nice when you can not only be informed, but also entertained I'm sure you had fun writing this article.

for a few of my sites but looking to change one of them over to a platform similar to yours as a trial run. Anything in particular you would recommend about it?